selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h
authorJohn Hubbard <jhubbard@nvidia.com>
Tue, 6 Jun 2023 07:16:33 +0000 (00:16 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 19 Jun 2023 23:19:02 +0000 (16:19 -0700)
This fixes a real bug, too, because xstate_size()  was assuming that
the stack variable xstate_size was initialized to zero. That's not
guaranteed nor even especially likely.

Link: https://lkml.kernel.org/r/20230606071637.267103-8-jhubbard@nvidia.com
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Tested-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/mm/pkey-x86.h

index 72c14cd..e32ae8a 100644 (file)
@@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void)
        unsigned int ecx;
        unsigned int edx;
        int xstate_offset;
-       int xstate_size;
+       int xstate_size = 0;
        unsigned long XSTATE_CPUID = 0xd;
        int leaf;