genlist: Fixed item select logic when item select mode is ALWAYS.
authorJae Yong Hwang <j_yong.hwang@samsung.com>
Thu, 21 Aug 2014 13:49:36 +0000 (22:49 +0900)
committerDaniel Juyung Seo <seojuyung2@gmail.com>
Thu, 21 Aug 2014 13:54:22 +0000 (22:54 +0900)
Summary:
ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode
was broken. In the item select routine, item mode(it->mode) was not
checked. So, I added the check routine there.

@fix

Test Plan: I revised the elementary_test code and tested with that.

Reviewers: raster, seoz

Reviewed By: seoz

Subscribers: SanghyeonLee, bluezery

Differential Revision: https://phab.enlightenment.org/D1347

src/lib/elm_genlist.c

index 0631279..6562704 100644 (file)
@@ -5546,7 +5546,8 @@ _item_select(Elm_Gen_Item *it)
         sd->selected =
           eina_list_append(sd->selected, it);
      }
-   else if (sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS)
+   else if ((sd->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS) &&
+            (it->select_mode != ELM_OBJECT_SELECT_MODE_ALWAYS))
      return;
 
    evas_object_ref(obj);