adaptivedemux: tests: remove unused demux_sent_eos callback
authorFlorin Apostol <florin.apostol@oregan.net>
Fri, 8 Jan 2016 16:25:12 +0000 (16:25 +0000)
committerThiago Santos <thiagoss@osg.samsung.com>
Tue, 9 Feb 2016 12:38:54 +0000 (09:38 -0300)
The demux_sent_eos callback is unused in tests. It was also registered on
a wrong pad, so it actually triggered when demux received eos from a
fragment download.

https://bugzilla.gnome.org/show_bug.cgi?id=760328

tests/check/elements/adaptive_demux_engine.c
tests/check/elements/adaptive_demux_engine.h

index 34ea252..a78d741 100644 (file)
@@ -215,13 +215,6 @@ on_demuxReceivesEvent (GstPad * pad, GstPadProbeInfo * info, gpointer data)
     stream->segment_received_size = 0;
     stream->segment_start = segment->start;
     GST_TEST_UNLOCK (priv);
-  } else if (GST_EVENT_TYPE (event) == GST_EVENT_EOS) {
-    GST_TEST_LOCK (priv);
-    stream = getTestOutputDataByPad (priv, pad, TRUE);
-    if (priv->callbacks->demux_sent_eos) {
-      priv->callbacks->demux_sent_eos (&priv->engine, stream, priv->user_data);
-    }
-    GST_TEST_UNLOCK (priv);
   }
 
   return GST_PAD_PROBE_OK;
index e232051..f715ecb 100644 (file)
@@ -136,17 +136,6 @@ typedef struct _GstAdaptiveDemuxTestCallbacks
       GstBuffer * buffer, gpointer user_data);
 
   /**
-   * demux_sent_eos: called each time demux send an EOS event
-   * @engine: #GstAdaptiveDemuxTestEngine
-   * @stream: #GstAdaptiveDemuxTestOutputStream
-   * @user_data: the user_data passed to gst_adaptive_demux_test_run()
-   * Can be used by a test to perform additional operations (eg validate
-   * output data)
-   */
-  void (*demux_sent_eos) (GstAdaptiveDemuxTestEngine *engine,
-      GstAdaptiveDemuxTestOutputStream * stream, gpointer user_data);
-  
-  /**
    * bus_error_message: called if an error is posted to the bus
    * @engine: #GstAdaptiveDemuxTestEngine
    * @msg: the #GstMessage that contains the error