[JSC] Asm-originated symbols should be marked as hidden

https://bugs.webkit.org/show_bug.cgi?id=77150

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-01-27
Reviewed by Filip Pizlo.

* dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
but they were missing in the CPU(X86) and the CPU(X86_64) cases.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index 4c121e7..031e184 100644 (file)
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,13 @@
+2012-01-27  Simon Hausmann  <simon.hausmann@nokia.com>
+
+        [JSC] Asm-originated symbols should be marked as hidden
+        https://bugs.webkit.org/show_bug.cgi?id=77150
+
+        Reviewed by Filip Pizlo.
+
+        * dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
+        but they were missing in the CPU(X86) and the CPU(X86_64) cases.
+
 2012-01-27  MORITA Hajime  <morrita@google.com>
 
         [JSC] Some JS_EXPORTDATA may not be necessary.

diff --git a/Source/JavaScriptCore/dfg/DFGOperations.cpp b/Source/JavaScriptCore/dfg/DFGOperations.cpp
index 3d4ce99..569b4fe 100644 (file)
--- a/Source/JavaScriptCore/dfg/DFGOperations.cpp
+++ b/Source/JavaScriptCore/dfg/DFGOperations.cpp
@@ -43,6 +43,7 @@
 #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, register) \
     asm( \
     ".globl " SYMBOL_STRING(function) "\n" \
+    HIDE_SYMBOL(function) "\n" \
     SYMBOL_STRING(function) ":" "\n" \
         "mov (%rsp), %" STRINGIZE(register) "\n" \
         "jmp " SYMBOL_STRING_RELOCATION(function##WithReturnAddress) "\n" \
@@ -57,6 +58,7 @@
 #define FUNCTION_WRAPPER_WITH_RETURN_ADDRESS(function, offset) \
     asm( \
     ".globl " SYMBOL_STRING(function) "\n" \
+    HIDE_SYMBOL(function) "\n" \
     SYMBOL_STRING(function) ":" "\n" \
         "mov (%esp), %eax\n" \
         "mov %eax, " STRINGIZE(offset) "(%esp)\n" \
@@ -677,6 +679,7 @@ EncodedJSValue DFG_OPERATION getHostCallReturnValueWithExecState(ExecState*);
 #if CPU(X86_64)
 asm (
 ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
+HIDE_SYMBOL(getHostCallReturnValue) "\n"
 SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
     "mov -40(%r13), %r13\n"
     "mov %r13, %rdi\n"
@@ -685,6 +688,7 @@ SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
 #elif CPU(X86)
 asm (
 ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
+HIDE_SYMBOL(getHostCallReturnValue) "\n"
 SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
     "mov -40(%edi), %edi\n"
     "mov %edi, 4(%esp)\n"