ASoC: pcm512x: Fix PM disable depth imbalance in pcm512x_probe

The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context. We fix it by going to
err_pm instead of err_clk.

Fixes:f086ba9d5389c ("ASoC: pcm512x: Support mastering BCLK/LRCLK using the PLL")

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20220928160402.126140-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c
index 767463e..89059a6 100644 (file)
--- a/sound/soc/codecs/pcm512x.c
+++ b/sound/soc/codecs/pcm512x.c
@@ -1634,7 +1634,7 @@ int pcm512x_probe(struct device *dev, struct regmap *regmap)
                        if (val > 6) {
                                dev_err(dev, "Invalid pll-in\n");
                                ret = -EINVAL;
-                               goto err_clk;
+                               goto err_pm;
                        }
                        pcm512x->pll_in = val;
                }
@@ -1643,7 +1643,7 @@ int pcm512x_probe(struct device *dev, struct regmap *regmap)
                        if (val > 6) {
                                dev_err(dev, "Invalid pll-out\n");
                                ret = -EINVAL;
-                               goto err_clk;
+                               goto err_pm;
                        }
                        pcm512x->pll_out = val;
                }
@@ -1652,12 +1652,12 @@ int pcm512x_probe(struct device *dev, struct regmap *regmap)
                        dev_err(dev,
                                "Error: both pll-in and pll-out, or none\n");
                        ret = -EINVAL;
-                       goto err_clk;
+                       goto err_pm;
                }
                if (pcm512x->pll_in && pcm512x->pll_in == pcm512x->pll_out) {
                        dev_err(dev, "Error: pll-in == pll-out\n");
                        ret = -EINVAL;
-                       goto err_clk;
+                       goto err_pm;
                }
        }
 #endif