Staging: Gasket: uninitialized return in gasket_mmap()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 6 Jul 2018 08:37:56 +0000 (11:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Jul 2018 15:35:42 +0000 (17:35 +0200)
We forgot to set the error code on this error path so ret can be
uninitialized.

Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_core.c

index 82b3eca..ad9442a 100644 (file)
@@ -1719,8 +1719,10 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
                /* Try the next region if this one was not mappable. */
                if (map_status == DO_MAP_REGION_INVALID)
                        continue;
-               if (map_status == DO_MAP_REGION_FAILURE)
+               if (map_status == DO_MAP_REGION_FAILURE) {
+                       ret = -ENOMEM;
                        goto fail;
+               }
 
                has_mapped_anything = 1;
        }