[ELF][MIPS] Support R_MIPS_GOT_HI16 / R_MIPS_GOT_LO16 relocations calculation
authorSimon Atanasyan <simon@atanasyan.com>
Thu, 18 Aug 2016 19:08:41 +0000 (19:08 +0000)
committerSimon Atanasyan <simon@atanasyan.com>
Thu, 18 Aug 2016 19:08:41 +0000 (19:08 +0000)
llvm-svn: 279119

lld/ELF/Target.cpp
lld/test/ELF/mips-got-hilo.s [new file with mode: 0644]

index ed44eaf..5404325 100644 (file)
@@ -1904,6 +1904,8 @@ RelExpr MipsTargetInfo<ELFT>::getRelExpr(uint32_t Type,
   case R_MIPS_CALL_HI16:
   case R_MIPS_CALL_LO16:
   case R_MIPS_GOT_DISP:
+  case R_MIPS_GOT_HI16:
+  case R_MIPS_GOT_LO16:
   case R_MIPS_TLS_GOTTPREL:
     return R_MIPS_GOT_OFF;
   case R_MIPS_GOT_PAGE:
@@ -2131,6 +2133,7 @@ void MipsTargetInfo<ELFT>::relocateOne(uint8_t *Loc, uint32_t Type,
   // fallthrough
   case R_MIPS_CALL16:
   case R_MIPS_CALL_LO16:
+  case R_MIPS_GOT_LO16:
   case R_MIPS_GOT_OFST:
   case R_MIPS_LO16:
   case R_MIPS_PCLO16:
@@ -2140,6 +2143,7 @@ void MipsTargetInfo<ELFT>::relocateOne(uint8_t *Loc, uint32_t Type,
     writeMipsLo16<E>(Loc, Val);
     break;
   case R_MIPS_CALL_HI16:
+  case R_MIPS_GOT_HI16:
   case R_MIPS_HI16:
   case R_MIPS_PCHI16:
   case R_MIPS_TLS_DTPREL_HI16:
diff --git a/lld/test/ELF/mips-got-hilo.s b/lld/test/ELF/mips-got-hilo.s
new file mode 100644 (file)
index 0000000..7e6945f
--- /dev/null
@@ -0,0 +1,64 @@
+# Check R_MIPS_GOT_HI16 / R_MIPS_GOT_LO16 relocations calculation.
+
+# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -shared -o %t.so
+# RUN: llvm-objdump -d %t.so | FileCheck %s
+# RUN: llvm-readobj -r -mips-plt-got %t.so | FileCheck -check-prefix=GOT %s
+
+# REQUIRES: mips
+
+# CHECK:      Disassembly of section .text:
+# CHECK-NEXT: foo:
+# CHECK-NEXT:    10000:       3c 02 00 00     lui     $2, 0
+# CHECK-NEXT:    10004:       8c 42 80 20     lw      $2, -32736($2)
+# CHECK-NEXT:    10008:       3c 02 00 00     lui     $2, 0
+# CHECK-NEXT:    1000c:       8c 42 80 18     lw      $2, -32744($2)
+# CHECK-NEXT:    10010:       3c 02 00 00     lui     $2, 0
+# CHECK-NEXT:    10014:       8c 42 80 1c     lw      $2, -32740($2)
+
+# GOT:      Relocations [
+# GOT-NEXT: ]
+
+# GOT:      Primary GOT {
+# GOT-NEXT:   Canonical gp value: 0x27FF0
+# GOT:        Local entries [
+# GOT-NEXT:     Entry {
+# GOT-NEXT:       Address: 0x20008
+# GOT-NEXT:       Access: -32744
+# GOT-NEXT:       Initial: 0x30000
+# GOT-NEXT:     }
+# GOT-NEXT:     Entry {
+# GOT-NEXT:       Address: 0x2000C
+# GOT-NEXT:       Access: -32740
+# GOT-NEXT:       Initial: 0x30004
+# GOT-NEXT:     }
+# GOT-NEXT:   ]
+# GOT-NEXT:   Global entries [
+# GOT-NEXT:     Entry {
+# GOT-NEXT:       Address: 0x20010
+# GOT-NEXT:       Access: -32736
+# GOT-NEXT:       Initial: 0x0
+# GOT-NEXT:       Value: 0x0
+# GOT-NEXT:       Type: None
+# GOT-NEXT:       Section: Undefined
+# GOT-NEXT:       Name: bar
+# GOT-NEXT:     }
+# GOT-NEXT:   ]
+# GOT-NEXT:   Number of TLS and multi-GOT entries: 0
+# GOT-NEXT: }
+
+  .text
+  .global foo
+foo:
+  lui   $2, %got_hi(bar)
+  lw    $2, %got_lo(bar)($2)
+  lui   $2, %got_hi(loc1)
+  lw    $2, %got_lo(loc1)($2)
+  lui   $2, %got_hi(loc2)
+  lw    $2, %got_lo(loc2)($2)
+
+  .data
+loc1:
+  .word 0
+loc2:
+  .word 0