io_uring/rsrc: always initialize 'folio' to NULL
authorJens Axboe <axboe@kernel.dk>
Fri, 24 Feb 2023 16:54:57 +0000 (09:54 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 24 Feb 2023 19:58:31 +0000 (12:58 -0700)
Smatch complains that:

smatch warnings:
io_uring/rsrc.c:1262 io_sqe_buffer_register() error: uninitialized symbol 'folio'.

'folio' may be used uninitialized, which can happen if we end up with a
single page mapped. Ensure that we clear folio to NULL at the top so
it's always set.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202302241432.YML1CD5C-lkp@intel.com/
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/rsrc.c

index aab1bc6..056f409 100644 (file)
@@ -1210,7 +1210,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, struct iovec *iov,
        unsigned long off;
        size_t size;
        int ret, nr_pages, i;
-       struct folio *folio;
+       struct folio *folio = NULL;
 
        *pimu = ctx->dummy_ubuf;
        if (!iov->iov_base)