lightnvm: fix memory leak when submit fails
authorPan Bian <bianpan2016@163.com>
Thu, 21 Jan 2021 07:22:02 +0000 (23:22 -0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 21 Jan 2021 12:45:51 +0000 (05:45 -0700)
The allocated page is not released if error occurs in
nvm_submit_io_sync_raw(). __free_page() is moved ealier to avoid
possible memory leak issue.

Fixes: aff3fb18f957 ("lightnvm: move bad block and chunk state logic to core")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/core.c

index c1bcac7..28ddcaa 100644 (file)
@@ -844,11 +844,10 @@ static int nvm_bb_chunk_sense(struct nvm_dev *dev, struct ppa_addr ppa)
        rqd.ppa_addr = generic_to_dev_addr(dev, ppa);
 
        ret = nvm_submit_io_sync_raw(dev, &rqd);
+       __free_page(page);
        if (ret)
                return ret;
 
-       __free_page(page);
-
        return rqd.error;
 }