I2C: the i2c controller is expected to be enabled when there is a
authorFei Yang <fei.yang@intel.com>
Mon, 7 Nov 2011 22:40:33 +0000 (14:40 -0800)
committermgross <mark.gross@intel.com>
Wed, 9 Nov 2011 21:21:22 +0000 (13:21 -0800)
transfer request. Runtiem resume should only power on and initialize
the device to a known default state. Enabling the device on runtime
resume would trigger a spurious interrupt even when there is no
function driver acutally using the i2c device, thus causing a kernel
panic as dev->msgs == NULL.

Change-Id: I708e0d532aa0cdd7cb5161d8643dd5186d193243
Signed-off-by: Fei Yang <fei.yang@intel.com>
Reviewed-on: http://android.intel.com:8080/23503
Reviewed-by: Gross, Mark <mark.gross@intel.com>
Tested-by: Gross, Mark <mark.gross@intel.com>
drivers/i2c/busses/i2c-designware-pcidrv.c

index 9e89e73..837dd22 100644 (file)
@@ -182,7 +182,6 @@ static int i2c_dw_pci_resume(struct device *dev)
        pci_restore_state(pdev);
 
        i2c_dw_init(i2c);
-       i2c_dw_enable(i2c);
        return 0;
 }