ASoC: mediatek: mt6358: fix UNINIT problem
authorTrevor Wu <trevor.wu@mediatek.com>
Tue, 7 Mar 2023 04:09:37 +0000 (12:09 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 13 Mar 2023 14:08:38 +0000 (14:08 +0000)
Coverity shows decaring variable reg without initializer. When
regmap_read returns an error, reg keeps the value left from earlier
computation. To prevent from the unexpected result in the case, assign
0 to reg.

Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Link: https://lore.kernel.org/r/20230307040938.7484-4-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/mt6358.c

index b54610b27906437b0ede084710fb6fc1d5007600..d7b157ddc9a8ba9c7825cc61dab7cfe2dfdff47a 100644 (file)
@@ -429,7 +429,7 @@ static int mt6358_put_volsw(struct snd_kcontrol *kcontrol,
        struct mt6358_priv *priv = snd_soc_component_get_drvdata(component);
        struct soc_mixer_control *mc =
                        (struct soc_mixer_control *)kcontrol->private_value;
-       unsigned int reg;
+       unsigned int reg = 0;
        int ret;
 
        ret = snd_soc_put_volsw(kcontrol, ucontrol);