Make some code cleaning

diff --git a/include/tty_imc.h b/include/tty_imc.h
index 623b591..ae95b9f 100644 (file)
--- a/include/tty_imc.h
+++ b/include/tty_imc.h
@@ -24,7 +24,6 @@
 #ifndef __TTY_IMC_DUMP_H__
 #define __TTY_IMC_DUMP_H__
 
-int tty_close(int fd);
 int tty_open (void);
 int ttyerr_open(void);
 

diff --git a/src/desc_imc_pr3.c b/src/desc_imc_pr3.c
index 0792876..e1cb40b 100644 (file)
--- a/src/desc_imc_pr3.c
+++ b/src/desc_imc_pr3.c
@@ -36,6 +36,8 @@
 
 #include "tty_imc.h"
 
+#define BUF_LEN_MAX 512
+
 struct custom_data {
        int tty_fd;
        guint watch_id_tty;
@@ -100,8 +102,6 @@ static gboolean on_recv_tty_message(GIOChannel *channel, GIOCondition condition,
 {
        TcoreHal *hal = data;
        struct custom_data *custom;
-
-       #define BUF_LEN_MAX 512
        char buf[BUF_LEN_MAX];
        int n = 0;
 
@@ -137,7 +137,7 @@ static guint register_gio_watch(TcoreHal *h, int fd, void *callback)
 
 static gboolean on_load()
 {
-       dbg("i'm load!");
+       dbg("I'm load!");
 
        return TRUE;
 }
@@ -150,19 +150,15 @@ static gboolean on_init(TcorePlugin *plugin)
        if (!plugin)
                return FALSE;
 
-       dbg("i'm init!");
+       dbg("I'm init!");
 
-       /*
-        * Phonet init
-        */
+       /* Phonet init */
        data = calloc(sizeof(struct custom_data), 1);
        memset(data, 0, sizeof(struct custom_data));
 
        data->tty_fd = tty_open();
 
-       /*
-        * HAL init
-        */
+       /* HAL init */
        hal = tcore_hal_new(plugin, "imc-pr3", &hops, TCORE_HAL_MODE_AT);
        tcore_hal_link_user_data(hal, data);
 
@@ -178,7 +174,7 @@ static void on_unload(TcorePlugin *plugin)
        if (!plugin)
                return;
 
-       dbg("i'm unload");
+       dbg("I'm unload");
 }
 
 struct tcore_plugin_define_desc plugin_define_desc =

diff --git a/src/tty_imc.c b/src/tty_imc.c
index 22a210b..5273240 100644 (file)
--- a/src/tty_imc.c
+++ b/src/tty_imc.c
@@ -35,15 +35,6 @@
 
 #define TTY_OPEN_PATH "/dev/ttyIFX0"
 
-int tty_close(int fd)
-{;
-       dbg("Function Enter");
-
-       close(fd);
-
-       return 0;
-}
-
 int tty_open (void)
 {
        int fd = -1;
@@ -66,7 +57,7 @@ int tty_open (void)
 
 int tty_read(int nFd, void* buf, size_t nbytes)
 {
-       int     actual = 0;
+       int actual = 0;
 
        dbg("Function Enter");
 
@@ -97,7 +88,7 @@ int tty_write(int nFd, void* buf, size_t nbytes)
 {
        int ret;
        size_t actual = 0;
-       int     retry = 0;
+       int retry = 0;
 
        do {
                ret = write(nFd, (unsigned char* )buf, nbytes - actual);