net: ocelot: delete call to br_fdb_replay
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sun, 27 Jun 2021 11:54:23 +0000 (14:54 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jun 2021 21:09:03 +0000 (14:09 -0700)
Not using this driver, I did not realize it doesn't react to
SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE notifications, but it implements just
the bridge bypass operations (.ndo_fdb_{add,del}). So the call to
br_fdb_replay just produces notifications that are ignored, delete it
for now.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot_net.c

index aad33d2..4fc74ee 100644 (file)
@@ -1165,10 +1165,6 @@ static int ocelot_switchdev_sync(struct ocelot *ocelot, int port,
        if (err && err != -EOPNOTSUPP)
                return err;
 
-       err = br_fdb_replay(bridge_dev, brport_dev, &ocelot_switchdev_nb);
-       if (err)
-               return err;
-
        err = br_vlan_replay(bridge_dev, brport_dev,
                             &ocelot_switchdev_blocking_nb, extack);
        if (err && err != -EOPNOTSUPP)