media: em28xx-audio: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Tue, 29 Sep 2020 13:14:25 +0000 (15:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:06 +0000 (10:31 +0100)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/em28xx/em28xx-audio.c

index dc968fd..4d5ab14 100644 (file)
@@ -583,9 +583,9 @@ static int em28xx_cvol_new(struct snd_card *card, struct em28xx *dev,
        struct snd_kcontrol_new tmp;
 
        memset(&tmp, 0, sizeof(tmp));
-       tmp.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
-       tmp.private_value = id,
-       tmp.name  = ctl_name,
+       tmp.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
+       tmp.private_value = id;
+       tmp.name  = ctl_name;
 
        /* Add Mute Control */
        sprintf(ctl_name, "%s Switch", name);
@@ -600,16 +600,16 @@ static int em28xx_cvol_new(struct snd_card *card, struct em28xx *dev,
                ctl_name, id);
 
        memset(&tmp, 0, sizeof(tmp));
-       tmp.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
-       tmp.private_value = id,
-       tmp.name  = ctl_name,
+       tmp.iface = SNDRV_CTL_ELEM_IFACE_MIXER;
+       tmp.private_value = id;
+       tmp.name  = ctl_name;
 
        /* Add Volume Control */
        sprintf(ctl_name, "%s Volume", name);
        tmp.get   = em28xx_vol_get;
        tmp.put   = em28xx_vol_put;
        tmp.info  = em28xx_vol_info;
-       tmp.tlv.p = em28xx_db_scale,
+       tmp.tlv.p = em28xx_db_scale;
        kctl = snd_ctl_new1(&tmp, dev);
        err = snd_ctl_add(card, kctl);
        if (err < 0)