bmaptool: fix --nobmap case
authorArtem Bityutskiy <artem.bityutskiy@intel.com>
Tue, 24 Sep 2013 09:55:07 +0000 (12:55 +0300)
committerArtem Bityutskiy <artem.bityutskiy@intel.com>
Mon, 30 Sep 2013 07:10:03 +0000 (10:10 +0300)
One of the previous commits introduced the NamedFile class and broke the
--nobmap case, because we created a NamedFile object even when f_bmap was None.
This patch fixes the problem.

Change-Id: I4592e06b1385dcf5d34b42717b0374c68d0c223f
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
bmaptool

index 8c92d3cc2b3dda9093f715e80a9da5084a509042..d3757813eb0c69af0915c9c895260c53b34a78e5 100755 (executable)
--- a/bmaptool
+++ b/bmaptool
@@ -425,17 +425,18 @@ def copy_command(args, log):
         bmap_obj.close()
         bmap_obj = f_obj
 
+    if bmap_obj:
+        bmap_obj = NamedFile(bmap_obj, bmap_path)
+
     try:
         if dest_is_blkdev:
             dest_str = "block device '%s'" % args.dest
             # For block devices, use the specialized class
-            writer = BmapCopy.BmapBdevCopy(image_obj, dest_obj,
-                                           NamedFile(bmap_obj, bmap_path),
+            writer = BmapCopy.BmapBdevCopy(image_obj, dest_obj, bmap_obj,
                                            image_size, logger=log)
         else:
             dest_str = "file '%s'" % os.path.basename(args.dest)
-            writer = BmapCopy.BmapCopy(image_obj, dest_obj,
-                                       NamedFile(bmap_obj, bmap_path),
+            writer = BmapCopy.BmapCopy(image_obj, dest_obj, bmap_obj,
                                        image_size, logger=log)
     except BmapCopy.Error as err:
         log.error(str(err))