Don't crash gsettings-schema-convert for GConf schemas that contain empty elements
authorRichard Hughes <richard@hughsie.com>
Tue, 20 Apr 2010 21:25:23 +0000 (22:25 +0100)
committerRichard Hughes <richard@hughsie.com>
Tue, 20 Apr 2010 21:30:01 +0000 (22:30 +0100)
This can be observed in gnome-power-manager with one of the entries that
contains <long></long>

gio/gsettings-schema-convert

index ff1127c..dcc4bef 100755 (executable)
@@ -792,8 +792,10 @@ class GConfSchema:
         self.short = self._get_value_with_locale(node, locale_node, 'short')
         self.long = self._get_value_with_locale(node, locale_node, 'long')
 
-        self.short = self._oneline(self.short)
-        self.long = self._oneline(self.long)
+        if self.short:
+            self.short = self._oneline(self.short)
+        if self.long:
+            self.long = self._oneline(self.long)
 
         # Fix the default to be parsable by GVariant
         if self.type == 'string':