gtp: update rx_length_errors for abnormally short packets

Based on work by Pravin Shelar.

Update appropriate stats when packet transmission isn't possible.

Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
Acked-by: Harald Welte <laforge@gnumonks.org>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index a1bb028189776cd99e9ce333ffa5729ccc879f39..9a70f05baf6e4cba17895084c1f59516d019da71 100644 (file)
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -189,8 +189,10 @@ static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,
 
        /* Get rid of the GTP + UDP headers. */
        if (iptunnel_pull_header(skb, hdrlen, skb->protocol,
-                                !net_eq(sock_net(pctx->sk), dev_net(pctx->dev))))
-               return -1;
+                        !net_eq(sock_net(pctx->sk), dev_net(pctx->dev)))) {
+               pctx->dev->stats.rx_length_errors++;
+               goto err;
+       }
 
        netdev_dbg(pctx->dev, "forwarding packet from GGSN to uplink\n");
 
@@ -206,6 +208,10 @@ static int gtp_rx(struct pdp_ctx *pctx, struct sk_buff *skb,
 
        netif_rx(skb);
        return 0;
+
+err:
+       pctx->dev->stats.rx_dropped++;
+       return -1;
 }
 
 /* 1 means pass up to the stack, -1 means drop and 0 means decapsulated. */