mtd: rawnand: cs553x: Stop using nand_release()

This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-9-miquel.raynal@bootlin.com

diff --git a/drivers/mtd/nand/raw/cs553x_nand.c b/drivers/mtd/nand/raw/cs553x_nand.c
index df5e24a2bbd7ba154d4116f9b2962866cab22cd4..9472bf798ed5092a1e6d14b47241cbd279a3e5e9 100644 (file)
--- a/drivers/mtd/nand/raw/cs553x_nand.c
+++ b/drivers/mtd/nand/raw/cs553x_nand.c
@@ -392,12 +392,15 @@ static void __exit cs553x_cleanup(void)
                struct cs553x_nand_controller *controller = controllers[i];
                struct nand_chip *this = &controller->chip;
                struct mtd_info *mtd = nand_to_mtd(this);
+               int ret;
 
                if (!mtd)
                        continue;
 
                /* Release resources, unregister device */
-               nand_release(this);
+               ret = mtd_device_unregister(mtd);
+               WARN_ON(ret);
+               nand_cleanup(this);
                kfree(mtd->name);
                controllers[i] = NULL;