powerpc/ps3: Remove an unneeded NULL check
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 27 Mar 2020 20:26:23 +0000 (20:26 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 2 Apr 2020 13:09:59 +0000 (00:09 +1100)
Static checkers don't like the inconsistent NULL checking on "ops".
This function is only called once and "ops" isn't NULL so the check
can be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/ddc3513dc54d15456692c80df49287fe3babe40a.1585340156.git.geoff@infradead.org
drivers/ps3/sys-manager-core.c

index 24709c5..e061b7d 100644 (file)
@@ -31,7 +31,7 @@ void ps3_sys_manager_register_ops(const struct ps3_sys_manager_ops *ops)
 {
        BUG_ON(!ops);
        BUG_ON(!ops->dev);
-       ps3_sys_manager_ops = ops ? *ops : ps3_sys_manager_ops;
+       ps3_sys_manager_ops = *ops;
 }
 EXPORT_SYMBOL_GPL(ps3_sys_manager_register_ops);