mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device
authorShawn Guo <shawn.guo@linaro.org>
Tue, 22 Jun 2021 00:39:18 +0000 (08:39 +0800)
committerJassi Brar <jaswinder.singh@linaro.org>
Sat, 26 Jun 2021 17:05:21 +0000 (12:05 -0500)
In adding APCS clock support for MSM8939, the second clock registration
fails due to duplicate device name like below.

[    0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk'
...
[    0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk

This is because MSM8939 has 3 APCS instances for Cluster0 (little cores),
Cluster1 (big cores) and CCI (Cache Coherent Interconnect).  Although
only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has
A53PLL clock control bits.  That said, 3 'qcom-apcs-msm8916-clk' devices
need to be registered to instantiate all 3 clocks.  Use PLATFORM_DEVID_AUTO
rather than PLATFORM_DEVID_NONE for platform_device_register_data() call
to fix the issue above.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/qcom-apcs-ipc-mailbox.c

index f24c5ad..16d1071 100644 (file)
@@ -136,7 +136,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
        if (apcs_data->clk_name) {
                apcs->clk = platform_device_register_data(&pdev->dev,
                                                          apcs_data->clk_name,
-                                                         PLATFORM_DEVID_NONE,
+                                                         PLATFORM_DEVID_AUTO,
                                                          NULL, 0);
                if (IS_ERR(apcs->clk))
                        dev_err(&pdev->dev, "failed to register APCS clk\n");