firmware: dmi_scan: Optimize dmi_save_extended_devices
authorJean Delvare <jdelvare@suse.de>
Fri, 15 Jan 2016 21:08:44 +0000 (22:08 +0100)
committerJean Delvare <jdelvare@suse.de>
Fri, 15 Jan 2016 21:08:44 +0000 (22:08 +0100)
Calling dmi_string_nosave isn't cheap, so avoid calling it twice in a
row for the same string.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Jordan Hargrave <jordan_hargrave@dell.com>
Cc: Narendra K <narendra_k@dell.com>
drivers/firmware/dmi_scan.c

index 0e08e66..28b2f0a 100644 (file)
@@ -345,15 +345,17 @@ static void __init dmi_save_dev_onboard(int instance, int segment, int bus,
 
 static void __init dmi_save_extended_devices(const struct dmi_header *dm)
 {
+       const char *name;
        const u8 *d = (u8 *) dm + 5;
 
        /* Skip disabled device */
        if ((*d & 0x80) == 0)
                return;
 
+       name = dmi_string_nosave(dm, *(d - 1));
        dmi_save_dev_onboard(*(d+1), *(u16 *)(d+2), *(d+4), *(d+5),
-                            dmi_string_nosave(dm, *(d-1)));
-       dmi_save_one_device(*d & 0x7f, dmi_string_nosave(dm, *(d - 1)));
+                            name);
+       dmi_save_one_device(*d & 0x7f, name);
 }
 
 static void __init count_mem_devices(const struct dmi_header *dm, void *v)