Fix memory leak

- url free after use
- server_addr free after use

Signed-off-by: SeokHoon Lee <andy.shlee@samsung.com>
Change-Id: I41bf5ca91ba19f43ea17de4d2cfa53a75afc4417

diff --git a/gst/rtsp-server/rtsp-client-wfd.c b/gst/rtsp-server/rtsp-client-wfd.c
index c07f802..7d3a475 100644 (file)
--- a/gst/rtsp-server/rtsp-client-wfd.c
+++ b/gst/rtsp-server/rtsp-client-wfd.c
@@ -3754,11 +3754,14 @@ prepare_transport_switch_request (GstRTSPWFDClient * client, GstRTSPMessage * re
   GstRTSPMethod method = GST_RTSP_SET_PARAMETER;
 
   url = g_strdup ("rtsp://localhost/wfd1.0");
+  if (!url)
+    return GST_RTSP_ERROR;
 
   GST_DEBUG_OBJECT (client, "Preparing request for transport switch");
 
   /* initialize the request */
   res = gst_rtsp_message_init_request (request, method, url);
+  g_free (url);
   if (res < 0) {
     GST_ERROR ("init request failed");
     return res;

diff --git a/gst/rtsp-server/rtsp-server-wfd.c b/gst/rtsp-server/rtsp-server-wfd.c
index 47cc17a..e3b3d05 100644 (file)
--- a/gst/rtsp-server/rtsp-server-wfd.c
+++ b/gst/rtsp-server/rtsp-server-wfd.c
@@ -194,10 +194,13 @@ _start_wfd (gpointer data)
 static void
 client_connected_wfd (GstRTSPServer * server, GstRTSPClient * client)
 {
+  gchar *server_addr = NULL;
   GST_INFO_OBJECT (server, "Client is connected");
 
+  server_addr = gst_rtsp_server_get_address (server);
   gst_rtsp_wfd_client_set_host_address (GST_RTSP_WFD_CLIENT_CAST (client),
-      gst_rtsp_server_get_address (server));
+      server_addr);
+  g_free (server_addr);
   g_idle_add (_start_wfd, client);
   return;
 }

diff --git a/packaging/gst-rtsp-server.spec b/packaging/gst-rtsp-server.spec
index d1636f2..f21da9b 100644 (file)
--- a/packaging/gst-rtsp-server.spec
+++ b/packaging/gst-rtsp-server.spec
@@ -1,7 +1,7 @@
 Name:       gst-rtsp-server
 Summary:    Multimedia Framework Library
 Version:    1.6.1
-Release:    11
+Release:    12
 Url:        http://gstreamer.freedesktop.org/
 Group:      System/Libraries
 License:    LGPL-2.0+