validate: override-registry: fix structs list leak
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Fri, 20 Mar 2015 10:33:01 +0000 (11:33 +0100)
committerGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Fri, 20 Mar 2015 10:33:01 +0000 (11:33 +0100)
The list returned by _lines_get_strutures() needs to be deeply freed.

validate/gst/validate/gst-validate-override-registry.c
validate/gst/validate/gst-validate-utils.c

index 7de89ef9e384037dab247b6a7911c04db3eea7b1..348243cb7831e5f645be73faa2cade4ceefa4fe3 100644 (file)
@@ -319,10 +319,14 @@ _load_text_override_file (const gchar * filename)
       }
     }
 
-    return ret;
+    goto done;
   }
 
-  return WRONG_FILE;
+  ret = WRONG_FILE;
+
+done:
+  g_list_free_full (structs, (GDestroyNotify) gst_structure_free);
+  return ret;
 }
 
 int
index 6022fd197c711017f9350e22abeb92783da1ba01..2fa9a177bc3e6783cf98784e85d2e1cf30378747 100644 (file)
@@ -596,6 +596,7 @@ _get_lines (const gchar * scenario_file)
   return lines;
 }
 
+/* Returns: (transfer full): a #GList of #GstStructure */
 static GList *
 _lines_get_strutures (gchar ** lines)
 {