RDMA/ipoib: Don't set constant driver version
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 20 Feb 2020 07:12:38 +0000 (09:12 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 27 Feb 2020 20:40:40 +0000 (16:40 -0400)
There is no need to set driver version in in-tree kernel code.

Link: https://lore.kernel.org/r/20200220071239.231800-2-leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/ulp/ipoib/ipoib.h
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c
drivers/infiniband/ulp/ipoib/ipoib_main.c

index 2aa3457..e188a95 100644 (file)
@@ -838,6 +838,4 @@ extern int ipoib_debug_level;
 
 #define IPOIB_QPN(ha) (be32_to_cpup((__be32 *) ha) & 0xffffff)
 
-extern const char ipoib_driver_version[];
-
 #endif /* _IPOIB_H */
index 63e4f9d..a47097d 100644 (file)
@@ -68,9 +68,6 @@ static void ipoib_get_drvinfo(struct net_device *netdev,
        strlcpy(drvinfo->bus_info, dev_name(priv->ca->dev.parent),
                sizeof(drvinfo->bus_info));
 
-       strlcpy(drvinfo->version, ipoib_driver_version,
-               sizeof(drvinfo->version));
-
        strlcpy(drvinfo->driver, "ib_ipoib", sizeof(drvinfo->driver));
 }
 
index 4a0d3a9..81b8227 100644 (file)
 #include <linux/inetdevice.h>
 #include <rdma/ib_cache.h>
 
-#define DRV_VERSION "1.0.0"
-
-const char ipoib_driver_version[] = DRV_VERSION;
-
 MODULE_AUTHOR("Roland Dreier");
 MODULE_DESCRIPTION("IP-over-InfiniBand net driver");
 MODULE_LICENSE("Dual BSD/GPL");