[clang-format] Handle template closer followed by braces (#110971)
authorOwen Pan <owenpiano@gmail.com>
Sat, 5 Oct 2024 01:18:03 +0000 (18:18 -0700)
committerTobias Hieta <tobias@hieta.se>
Tue, 15 Oct 2024 06:55:16 +0000 (08:55 +0200)
Fixes #110968.

(cherry picked from commit e5b05a51b8151cc7788bbdea4d491e5ccfceedea)

clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/TokenAnnotatorTest.cpp

index f7b3561f6e033508c42bce1bf65cc7f16c7f5ff5..631c7c62baac188892d8eaf09f25d5a2ea67dc58 100644 (file)
@@ -2131,6 +2131,11 @@ void UnwrappedLineParser::parseStructuralElement(
         return;
       }
       break;
+    case tok::greater:
+      nextToken();
+      if (FormatTok->is(tok::l_brace))
+        FormatTok->Previous->setFinalizedType(TT_TemplateCloser);
+      break;
     default:
       nextToken();
       break;
index 2f09b380a87134ae4686ffa6aa0c18faa401eb8e..6f3ef3b646c619f39f55384f40ade8dcce00d551 100644 (file)
@@ -3399,6 +3399,11 @@ TEST_F(TokenAnnotatorTest, TemplateInstantiation) {
   ASSERT_EQ(Tokens.size(), 11u) << Tokens;
   EXPECT_TOKEN(Tokens[2], tok::less, TT_TemplateOpener);
   EXPECT_TOKEN(Tokens[6], tok::greater, TT_TemplateCloser);
+
+  Tokens = annotate("return std::conditional_t<T::value == U::value, T, U>{};");
+  ASSERT_EQ(Tokens.size(), 21u) << Tokens;
+  EXPECT_TOKEN(Tokens[4], tok::less, TT_TemplateOpener);
+  EXPECT_TOKEN(Tokens[16], tok::greater, TT_TemplateCloser);
 }
 
 } // namespace