e_test_event: free globals iterator when function end 00/183100/1
authorJunSeok, Kim <juns.kim@samsung.com>
Mon, 2 Jul 2018 07:11:39 +0000 (16:11 +0900)
committerJunSeok, Kim <juns.kim@samsung.com>
Mon, 2 Jul 2018 07:11:39 +0000 (16:11 +0900)
fix coverity

Change-Id: Ibcba9bc85e38b16b6412a75c96f912fd74c7c98c

src/e_test_event.cpp

index 19e61fb..8e0acc5 100644 (file)
@@ -850,8 +850,8 @@ etRunner::initProtocols()
    registry = ecore_wl2_display_registry_get(ecore_wl2_connected_display_get(NULL));
    globals = ecore_wl2_display_globals_get(ecore_wl2_connected_display_get(NULL));
 
-   EINA_SAFETY_ON_NULL_RETURN_VAL(registry, EINA_FALSE);
-   EINA_SAFETY_ON_NULL_RETURN_VAL(globals, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_GOTO(registry, err);
+   EINA_SAFETY_ON_NULL_GOTO(globals, err);
 
    EINA_ITERATOR_FOREACH(globals, global)
      {
@@ -873,10 +873,16 @@ etRunner::initProtocols()
           }
      }
 
-   EINA_SAFETY_ON_NULL_RETURN_VAL(tzPolicy, EINA_FALSE);
-   EINA_SAFETY_ON_NULL_RETURN_VAL(tzSurface, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_GOTO(tzPolicy, err);
+   EINA_SAFETY_ON_NULL_GOTO(tzSurface, err);
 
+   eina_iterator_free(globals);
    return EINA_TRUE;
+
+err:
+   if (globals)
+     eina_iterator_free(globals);
+   return EINA_FALSE;
 }
 
 /* callbacks - method */