forked child may not exit correctly if it failed to open

/dev/console (from Graham Barr)

p4raw-id: //depot/perl@5985

diff --git a/ext/Sys/Syslog/Syslog.pm b/ext/Sys/Syslog/Syslog.pm
index d109a9d..95f89ce 100644 (file)
--- a/ext/Sys/Syslog/Syslog.pm
+++ b/ext/Sys/Syslog/Syslog.pm
@@ -244,9 +244,9 @@ sub syslog {
            else {
                if (open(CONS,">/dev/console")) {
                    print CONS "<$facility.$priority>$whoami: $message\r";
-                   exit if defined $pid;               # if fork failed, we're parent
                    close CONS;
                }
+               exit if defined $pid;           # if fork failed, we're parent
            }
        }
     }