io_uring: keep io_req_free_batch() call locality
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 19 Mar 2021 17:22:32 +0000 (17:22 +0000)
committerJens Axboe <axboe@kernel.dk>
Sun, 11 Apr 2021 23:41:58 +0000 (17:41 -0600)
Don't do a function call (io_dismantle_req()) in the middle and place it
to near other function calls, otherwise may lead to excessive register
spilling.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 1c846d5..7bbecf4 100644 (file)
@@ -2112,6 +2112,7 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req,
                              struct io_submit_state *state)
 {
        io_queue_next(req);
+       io_dismantle_req(req);
 
        if (req->task != rb->task) {
                if (rb->task)
@@ -2122,7 +2123,6 @@ static void io_req_free_batch(struct req_batch *rb, struct io_kiocb *req,
        rb->task_refs++;
        rb->ctx_refs++;
 
-       io_dismantle_req(req);
        if (state->free_reqs != ARRAY_SIZE(state->reqs))
                state->reqs[state->free_reqs++] = req;
        else