net: ethernet: adi: adin1110: Fix uninitialized variable
authorDell Jin <dell.jin.code@outlook.com>
Fri, 20 Oct 2023 06:20:53 +0000 (09:20 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Oct 2023 10:54:42 +0000 (11:54 +0100)
The spi_transfer struct has to have all it's fields initialized to 0 in
this case, since not all of them are set before starting the transfer.
Otherwise, spi_sync_transfer() will sometimes return an error.

Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")
Signed-off-by: Dell Jin <dell.jin.code@outlook.com>
Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/adi/adin1110.c

index ca66b74..d7c274a 100644 (file)
@@ -294,7 +294,7 @@ static int adin1110_read_fifo(struct adin1110_port_priv *port_priv)
 {
        struct adin1110_priv *priv = port_priv->priv;
        u32 header_len = ADIN1110_RD_HEADER_LEN;
-       struct spi_transfer t;
+       struct spi_transfer t = {0};
        u32 frame_size_no_fcs;
        struct sk_buff *rxb;
        u32 frame_size;