evas bmp loader - fix warnings about same type handled twice 10/143310/2
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Fri, 28 Jul 2017 11:39:44 +0000 (20:39 +0900)
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>
Fri, 11 Aug 2017 00:17:05 +0000 (00:17 +0000)
so a type we handle earlir inan if we re-handle as invalid later. this
wouldnt lead to a crash or bugs as the if's would ned to be evaluated
in order normally, but it's good to get it right.

found by PVS studio

Change-Id: I03b0315fbb938d34b4221f44376dd77ca294cf36

src/modules/evas/image_loaders/bmp/evas_image_load_bmp.c

index f798333..a8f8b6e 100644 (file)
@@ -436,7 +436,7 @@ evas_image_load_file_head_bmp(void *loader_data,
           }
         else if (header.comp == 4) // jpeg - only printer drivers
           goto close_file;
-        else if (header.comp == 3) // png - only printer drivers
+        else if (header.comp == 5) // png - only printer drivers
           goto close_file;
         else
           goto close_file;
@@ -1405,7 +1405,7 @@ evas_image_load_file_data_bmp(void *loader_data,
           {
              goto close_file;
           }
-        else if (header.comp == 3) // png - only printer drivers
+        else if (header.comp == 5) // png - only printer drivers
           {
              goto close_file;
           }