ac/nir: fix a typo in ac_are_tessfactors_def_in_all_invocs
authorMarek Olšák <marek.olsak@amd.com>
Sat, 14 Nov 2020 04:13:45 +0000 (23:13 -0500)
committerMarge Bot <eric+marge@anholt.net>
Mon, 23 Nov 2020 02:22:20 +0000 (02:22 +0000)
I think it only made the pass return false if there was a barrier

Fixes: 2832bc972bf - ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7623>

src/amd/llvm/ac_nir_to_llvm.c

index 3517eaa..4cb1e13 100644 (file)
@@ -4990,7 +4990,7 @@ static void scan_tess_ctrl(nir_cf_node *cf_node, unsigned *upper_block_tf_writem
              * such segment that writes tess factor channels should write the same
              * channels in all codepaths within that segment.
              */
-            if (upper_block_tf_writemask || cond_block_tf_writemask) {
+            if (*upper_block_tf_writemask || *cond_block_tf_writemask) {
                /* Accumulate the result: */
                *tessfactors_are_def_in_all_invocs &=
                   !(*cond_block_tf_writemask & ~(*upper_block_tf_writemask));