clk: test: Fix type sign of rounded rate variables
authorMaxime Ripard <maxime@cerno.tech>
Fri, 5 May 2023 11:25:04 +0000 (13:25 +0200)
committerStephen Boyd <sboyd@kernel.org>
Fri, 9 Jun 2023 01:01:05 +0000 (18:01 -0700)
clk_round_rate() may return a negative error code, but most of the
variables we defined to store its returned value are unsigned.

This obviously leads to issues on error.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v4-2-971d5077e7d2@cerno.tech
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk_test.c

index f9a5c2964c65dc17e97c0b2ba3c89fc0db285182..2cb51153750d82e907a39f8ca2ab30e0407effab 100644 (file)
@@ -266,7 +266,8 @@ static void clk_test_round_set_get_rate(struct kunit *test)
        struct clk_dummy_context *ctx = test->priv;
        struct clk_hw *hw = &ctx->hw;
        struct clk *clk = clk_hw_get_clk(hw, NULL);
-       unsigned long rounded_rate, set_rate;
+       unsigned long set_rate;
+       long rounded_rate;
 
        rounded_rate = clk_round_rate(clk, DUMMY_CLOCK_RATE_1);
        KUNIT_ASSERT_GT(test, rounded_rate, 0);
@@ -851,7 +852,7 @@ clk_test_orphan_transparent_multiple_parent_mux_set_range_round_rate(struct kuni
        struct clk_multiple_parent_ctx *ctx = test->priv;
        struct clk_hw *hw = &ctx->hw;
        struct clk *clk = clk_hw_get_clk(hw, NULL);
-       unsigned long rate;
+       long rate;
        int ret;
 
        ret = clk_set_rate_range(clk, DUMMY_CLOCK_RATE_1, DUMMY_CLOCK_RATE_2);
@@ -1090,7 +1091,7 @@ clk_test_single_parent_mux_set_range_round_rate_parent_only(struct kunit *test)
        struct clk_hw *hw = &ctx->hw;
        struct clk *clk = clk_hw_get_clk(hw, NULL);
        struct clk *parent;
-       unsigned long rate;
+       long rate;
        int ret;
 
        parent = clk_get_parent(clk);
@@ -1120,7 +1121,7 @@ clk_test_single_parent_mux_set_range_round_rate_child_smaller(struct kunit *test
        struct clk_hw *hw = &ctx->hw;
        struct clk *clk = clk_hw_get_clk(hw, NULL);
        struct clk *parent;
-       unsigned long rate;
+       long rate;
        int ret;
 
        parent = clk_get_parent(clk);
@@ -1158,7 +1159,7 @@ clk_test_single_parent_mux_set_range_round_rate_parent_smaller(struct kunit *tes
        struct clk_hw *hw = &ctx->hw;
        struct clk *clk = clk_hw_get_clk(hw, NULL);
        struct clk *parent;
-       unsigned long rate;
+       long rate;
        int ret;
 
        parent = clk_get_parent(clk);