process: improve process binding

Reviewed-By: Fedor Indutny <fedor@indutny.com>

diff --git a/src/node.cc b/src/node.cc
index 61a5cfd..f3409dc 100644 (file)
--- a/src/node.cc
+++ b/src/node.cc
@@ -2240,7 +2240,12 @@ static void Binding(const FunctionCallbackInfo<Value>& args) {
     DefineJavaScript(env, exports);
     cache->Set(module, exports);
   } else {
-    return env->ThrowError("No such module");
+    char errmsg[1024];
+    snprintf(errmsg,
+             sizeof(errmsg),
+             "No such module: %s",
+             *module_v);
+    return env->ThrowError(errmsg);
   }
 
   args.GetReturnValue().Set(exports);

diff --git a/test/simple/test-process-binding.js b/test/simple/test-process-binding.js
new file mode 100644 (file)
index 0000000..c803a80
--- /dev/null
+++ b/test/simple/test-process-binding.js
@@ -0,0 +1,16 @@
+var assert = require('assert');
+
+assert.throws(
+  function() {
+    process.binding('test');
+  },
+  /No such module: test/
+);
+
+assert.doesNotThrow(function () {
+  process.binding('buffer');
+}, function(err) {
+  if ( (err instanceof Error) ) {
+    return true;
+  }
+}, "unexpected error");