spi: atmel: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 15:27:05 +0000 (17:27 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 8 Sep 2020 17:19:24 +0000 (18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20200901152713.18629-3-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-atmel.c

index 2cfe625..7c68d5c 100644 (file)
@@ -513,9 +513,8 @@ static int atmel_spi_configure_dma(struct spi_master *master,
 
        master->dma_tx = dma_request_chan(dev, "tx");
        if (IS_ERR(master->dma_tx)) {
-               err = PTR_ERR(master->dma_tx);
-               if (err != -EPROBE_DEFER)
-                       dev_err(dev, "No TX DMA channel, DMA is disabled\n");
+               err = dev_err_probe(dev, PTR_ERR(master->dma_tx),
+                                   "No TX DMA channel, DMA is disabled\n");
                goto error_clear;
        }