nir/idiv_const: improve idiv(n, INT_MIN)
authorRhys Perry <pendingchaos02@gmail.com>
Wed, 21 Jul 2021 16:15:51 +0000 (17:15 +0100)
committerMarge Bot <eric+marge@anholt.net>
Mon, 9 Aug 2021 11:00:39 +0000 (11:00 +0000)
This lowering is smaller and -INT64_MIN is probably UB (signed overflow).

No fossil-db changes.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12039>

src/compiler/nir/nir_opt_idiv_const.c

index 44daa79..f94efc5 100644 (file)
@@ -65,6 +65,10 @@ build_umod(nir_builder *b, nir_ssa_def *n, uint64_t d)
 static nir_ssa_def *
 build_idiv(nir_builder *b, nir_ssa_def *n, int64_t d)
 {
+   int64_t int_min = u_intN_min(n->bit_size);
+   if (d == int_min)
+      return nir_b2i(b, nir_ieq_imm(b, n, int_min), n->bit_size);
+
    uint64_t abs_d = d < 0 ? -d : d;
 
    if (d == 0) {