drm/i915/debugfs: Increment return value of gt.next_seqno
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 24 Nov 2016 09:47:52 +0000 (09:47 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 24 Nov 2016 12:27:29 +0000 (12:27 +0000)
The i915_next_seqno read value is to be the next seqno used by the
kernel. However, in the conversion to atomics ops for gt.next_seqno, in
commit 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during
request allocation"), this was changed from a post-increment to a
pre-increment. This increment was missed from the value reported by
debugfs, so in effect it was reporting the current seqno (last
assigned), not the next seqno.

Fixes: 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during request allocation")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81209
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161124094752.19129-1-chris@chris-wilson.co.uk
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
drivers/gpu/drm/i915/i915_debugfs.c

index 86825d0..0c6323e 100644 (file)
@@ -1026,7 +1026,7 @@ i915_next_seqno_get(void *data, u64 *val)
 {
        struct drm_i915_private *dev_priv = data;
 
-       *val = atomic_read(&dev_priv->gt.global_timeline.next_seqno);
+       *val = 1 + atomic_read(&dev_priv->gt.global_timeline.next_seqno);
        return 0;
 }