[gn build] Fix defines define on Windows
authorShoaib Meenai <smeenai@fb.com>
Wed, 12 Dec 2018 23:57:21 +0000 (23:57 +0000)
committerShoaib Meenai <smeenai@fb.com>
Wed, 12 Dec 2018 23:57:21 +0000 (23:57 +0000)
On Windows, we won't go into the `host_os != "win"` block, so `defines`
won't have been defined, and we'll run into an undefined identifier
error when we try to later append to it. Unconditionally define it at
the start and append to it everywhere else.

Differential Revision: https://reviews.llvm.org/D55617

llvm-svn: 348993

llvm/utils/gn/build/BUILD.gn

index 0f369ec..37aa431 100644 (file)
@@ -3,9 +3,11 @@ import("//llvm/utils/gn/build/mac_sdk.gni")
 import("//llvm/utils/gn/build/toolchain/compiler.gni")
 
 config("compiler_defaults") {
+  defines = []
+
   # FIXME: Don't define this globally here.
   if (host_os != "win") {
-    defines = [ "LLVM_ON_UNIX" ]
+    defines += [ "LLVM_ON_UNIX" ]
   }
 
   if (!llvm_enable_assertions) {