projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f1fcbaa
)
x86/unwind/orc: Use swap() instead of open coding it
author
Jiapeng Chong
<jiapeng.chong@linux.alibaba.com>
Thu, 30 Mar 2023 02:00:14 +0000
(10:00 +0800)
committer
Josh Poimboeuf
<jpoimboe@kernel.org>
Tue, 16 May 2023 13:06:56 +0000
(06:06 -0700)
Swap is a function interface that provides exchange function. To avoid
code duplication, we can use swap function.
./arch/x86/kernel/unwind_orc.c:235:16-17: WARNING opportunity for swap().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link:
https://bugzilla.openanolis.cn/show_bug.cgi?id=4641
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link:
https://lore.kernel.org/r/20230330020014.40489-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/x86/kernel/unwind_orc.c
patch
|
blob
|
history
diff --git
a/arch/x86/kernel/unwind_orc.c
b/arch/x86/kernel/unwind_orc.c
index 3ac50b7298d15a82114663effa26cf8c13d99a8a..5fbcb229f707efd934b90c7196e04858994e99c1 100644
(file)
--- a/
arch/x86/kernel/unwind_orc.c
+++ b/
arch/x86/kernel/unwind_orc.c
@@
-219,7
+219,6
@@
static struct orc_entry *cur_orc_table = __start_orc_unwind;
static void orc_sort_swap(void *_a, void *_b, int size)
{
struct orc_entry *orc_a, *orc_b;
- struct orc_entry orc_tmp;
int *a = _a, *b = _b, tmp;
int delta = _b - _a;
@@
-231,9
+230,7
@@
static void orc_sort_swap(void *_a, void *_b, int size)
/* Swap the corresponding .orc_unwind entries: */
orc_a = cur_orc_table + (a - cur_orc_ip_table);
orc_b = cur_orc_table + (b - cur_orc_ip_table);
- orc_tmp = *orc_a;
- *orc_a = *orc_b;
- *orc_b = orc_tmp;
+ swap(*orc_a, *orc_b);
}
static int orc_sort_cmp(const void *_a, const void *_b)