tap: Finish conversion of tap_open() to Error
authorMarkus Armbruster <armbru@redhat.com>
Fri, 15 May 2015 11:59:02 +0000 (13:59 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 27 May 2015 09:34:07 +0000 (10:34 +0100)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 1431691143-1015-15-git-send-email-armbru@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
net/tap.c

index 362df42..c1ee4f1 100644 (file)
--- a/net/tap.c
+++ b/net/tap.c
@@ -597,10 +597,6 @@ static int net_tap_init(const NetdevTapOptions *tap, int *vnet_hdr,
     TFR(fd = tap_open(ifname, ifname_sz, vnet_hdr, vnet_hdr_required,
                       mq_required, errp));
     if (fd < 0) {
-        /* FIXME drop when all tap_open() store an Error */
-        if (errp && !*errp) {
-            error_setg(errp, "can't open tap device");
-        }
         return -1;
     }