kernfs: remove an unused if statement in kernfs_path_from_node_locked()
authorZhen Lei <thunder.leizhen@huawei.com>
Sat, 26 Nov 2022 11:16:34 +0000 (19:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jan 2023 16:13:24 +0000 (17:13 +0100)
It makes no sense to call kernfs_path_from_node_locked() with NULL buf,
and no one is doing that right now.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20221126111634.1994-1-thunder.leizhen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/dir.c

index 935ef8c..7b13b1c 100644 (file)
@@ -149,9 +149,6 @@ static int kernfs_path_from_node_locked(struct kernfs_node *kn_to,
        if (kn_from == kn_to)
                return strlcpy(buf, "/", buflen);
 
-       if (!buf)
-               return -EINVAL;
-
        common = kernfs_common_ancestor(kn_from, kn_to);
        if (WARN_ON(!common))
                return -EINVAL;