KVM: arm/arm64: Don't queue VLPIs on INV/INVALL
authorChristoffer Dall <christoffer.dall@linaro.org>
Fri, 10 Nov 2017 08:34:54 +0000 (09:34 +0100)
committerChristoffer Dall <christoffer.dall@linaro.org>
Fri, 10 Nov 2017 08:59:20 +0000 (09:59 +0100)
Since VLPIs are injected directly by the hardware there's no need to
mark these as pending in software and queue them on the AP list.

Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
virt/kvm/arm/vgic/vgic-its.c

index c93ecd4..a3754ec 100644 (file)
@@ -292,11 +292,14 @@ static int update_lpi_config(struct kvm *kvm, struct vgic_irq *irq,
                irq->priority = LPI_PROP_PRIORITY(prop);
                irq->enabled = LPI_PROP_ENABLE_BIT(prop);
 
-               vgic_queue_irq_unlock(kvm, irq, flags);
-       } else {
-               spin_unlock_irqrestore(&irq->irq_lock, flags);
+               if (!irq->hw) {
+                       vgic_queue_irq_unlock(kvm, irq, flags);
+                       return 0;
+               }
        }
 
+       spin_unlock_irqrestore(&irq->irq_lock, flags);
+
        if (irq->hw)
                return its_prop_update_vlpi(irq->host_irq, prop, needs_inv);