Now that we set ThreadPlanCallFunction to private in the constructor, it is confusing...
authorJim Ingham <jingham@apple.com>
Fri, 7 Dec 2012 19:04:31 +0000 (19:04 +0000)
committerJim Ingham <jingham@apple.com>
Fri, 7 Dec 2012 19:04:31 +0000 (19:04 +0000)
again in client code after creating the plans.  So remove those unnecessary calls.

llvm-svn: 169625

lldb/source/Expression/ClangFunction.cpp
lldb/source/Expression/ClangUserExpression.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp

index 988bad5..bab93f0 100644 (file)
@@ -517,9 +517,7 @@ ClangFunction::ExecuteFunction (
                                                                                  this_arg));
     if (!call_plan_sp)
         return eExecutionSetupError;
-    
-    call_plan_sp->SetPrivate(true);
-    
+        
     // <rdar://problem/12027563> we need to make sure we record the fact that we are running an expression here
     // otherwise this fact will fail to be recorded when fetching an Objective-C object description
     if (exe_ctx.GetProcessPtr())
index 13b7b0e..81db328 100644 (file)
@@ -633,9 +633,7 @@ ClangUserExpression::Execute (Stream &error_stream,
             return eExecutionSetupError;
         
         lldb::addr_t function_stack_pointer = static_cast<ThreadPlanCallFunction *>(call_plan_sp.get())->GetFunctionStackPointer();
-    
-        call_plan_sp->SetPrivate(true);
-    
+
         if (log)
             log->Printf("-- [ClangUserExpression::Execute] Execution of expression begins --");
         
index 3b778e8..18667d6 100644 (file)
@@ -86,7 +86,6 @@ AppleThreadPlanStepThroughObjCTrampoline::InitializeClangFunction ()
         ExecutionContext exc_ctx;
         m_thread.CalculateExecutionContext(exc_ctx);
         m_func_sp.reset(m_impl_function->GetThreadPlanToCallFunction (exc_ctx, m_args_addr, errors, m_stop_others));
-        m_func_sp->SetPrivate(true);
         m_func_sp->SetOkayToDiscard(true);
         m_thread.QueueThreadPlan (m_func_sp, false);
     }