drm/tinydrm: Drop driver registered message

No need to put out a driver registered message since drm_dev_register()
does that now. SPI speed is an important metric when dealing with
display problems, so retain that info.

Cc: David Lechner <david@lechnology.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: David Lechner <david@lechnology.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1504883250-43487-8-git-send-email-noralf@tronnes.org

diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/tinydrm/mi0283qt.c
index 7e5bb7d..7fd2691 100644 (file)
--- a/drivers/gpu/drm/tinydrm/mi0283qt.c
+++ b/drivers/gpu/drm/tinydrm/mi0283qt.c
@@ -163,7 +163,6 @@ MODULE_DEVICE_TABLE(spi, mi0283qt_id);
 static int mi0283qt_probe(struct spi_device *spi)
 {
        struct device *dev = &spi->dev;
-       struct tinydrm_device *tdev;
        struct mipi_dbi *mipi;
        struct gpio_desc *dc;
        u32 rotation = 0;
@@ -215,20 +214,9 @@ static int mi0283qt_probe(struct spi_device *spi)
                return ret;
        }
 
-       tdev = &mipi->tinydrm;
-
-       ret = devm_tinydrm_register(tdev);
-       if (ret)
-               return ret;
-
        spi_set_drvdata(spi, mipi);
 
-       DRM_DEBUG_DRIVER("Initialized %s:%s @%uMHz on minor %d\n",
-                        tdev->drm->driver->name, dev_name(dev),
-                        spi->max_speed_hz / 1000000,
-                        tdev->drm->primary->index);
-
-       return 0;
+       return devm_tinydrm_register(&mipi->tinydrm);
 }
 
 static void mi0283qt_shutdown(struct spi_device *spi)

diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
index 2caeabc..f0dedc2 100644 (file)
--- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
+++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
@@ -842,6 +842,8 @@ int mipi_dbi_spi_init(struct spi_device *spi, struct mipi_dbi *mipi,
                        return -ENOMEM;
        }
 
+       DRM_DEBUG_DRIVER("SPI speed: %uMHz\n", spi->max_speed_hz / 1000000);
+
        return 0;
 }
 EXPORT_SYMBOL(mipi_dbi_spi_init);

diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tinydrm/repaper.c
index 30dc97b..5fbe147 100644 (file)
--- a/drivers/gpu/drm/tinydrm/repaper.c
+++ b/drivers/gpu/drm/tinydrm/repaper.c
@@ -1078,19 +1078,11 @@ static int repaper_probe(struct spi_device *spi)
                return ret;
 
        drm_mode_config_reset(tdev->drm);
-
-       ret = devm_tinydrm_register(tdev);
-       if (ret)
-               return ret;
-
        spi_set_drvdata(spi, tdev);
 
-       DRM_DEBUG_DRIVER("Initialized %s:%s @%uMHz on minor %d\n",
-                        tdev->drm->driver->name, dev_name(dev),
-                        spi->max_speed_hz / 1000000,
-                        tdev->drm->primary->index);
+       DRM_DEBUG_DRIVER("SPI speed: %uMHz\n", spi->max_speed_hz / 1000000);
 
-       return 0;
+       return devm_tinydrm_register(tdev);
 }
 
 static void repaper_shutdown(struct spi_device *spi)

diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tinydrm/st7586.c
index b439956..07b4d31 100644 (file)
--- a/drivers/gpu/drm/tinydrm/st7586.c
+++ b/drivers/gpu/drm/tinydrm/st7586.c
@@ -343,7 +343,6 @@ MODULE_DEVICE_TABLE(spi, st7586_id);
 static int st7586_probe(struct spi_device *spi)
 {
        struct device *dev = &spi->dev;
-       struct tinydrm_device *tdev;
        struct mipi_dbi *mipi;
        struct gpio_desc *a0;
        u32 rotation = 0;
@@ -388,20 +387,9 @@ static int st7586_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       tdev = &mipi->tinydrm;
-
-       ret = devm_tinydrm_register(tdev);
-       if (ret)
-               return ret;
-
        spi_set_drvdata(spi, mipi);
 
-       DRM_DEBUG_DRIVER("Initialized %s:%s @%uMHz on minor %d\n",
-                        tdev->drm->driver->name, dev_name(dev),
-                        spi->max_speed_hz / 1000000,
-                        tdev->drm->primary->index);
-
-       return 0;
+       return devm_tinydrm_register(&mipi->tinydrm);
 }
 
 static void st7586_shutdown(struct spi_device *spi)