net: ipa: don't configure IDLE_INDICATION on v3.1
authorCaleb Connolly <caleb.connolly@linaro.org>
Mon, 24 Oct 2022 23:48:50 +0000 (00:48 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 26 Oct 2022 02:49:13 +0000 (19:49 -0700)
IPA v3.1 doesn't support the IDLE_INDICATION_CFG register, this was
causing a harmless splat in ipa_idle_indication_cfg(), add a version
check to prevent trying to fetch this register on v3.1

Fixes: 6a244b75cfab ("net: ipa: introduce ipa_reg()")
Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Tested-by: Jami Kettunen <jami.kettunen@somainline.org>
Link: https://lore.kernel.org/r/20221024234850.4049778-1-caleb.connolly@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_main.c

index 3461ad3..49537fc 100644 (file)
@@ -434,6 +434,9 @@ static void ipa_idle_indication_cfg(struct ipa *ipa,
        const struct ipa_reg *reg;
        u32 val;
 
+       if (ipa->version < IPA_VERSION_3_5_1)
+               return;
+
        reg = ipa_reg(ipa, IDLE_INDICATION_CFG);
        val = ipa_reg_encode(reg, ENTER_IDLE_DEBOUNCE_THRESH,
                             enter_idle_debounce_thresh);