crypto: cavium/nitrox - don't cast parameter in bit operations

While in this particular case it would not be a (critical) issue,
the pattern itself is bad and error prone in case the location
of the parameter is changed.

Don't cast parameter to unsigned long pointer in the bit operations.
Instead copy to a local variable on stack of a proper type and use.

Fixes: cf718eaa8f9b ("crypto: cavium/nitrox - Enabled Mailbox support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/cavium/nitrox/nitrox_mbx.c b/drivers/crypto/cavium/nitrox/nitrox_mbx.c
index 2e9c0d2..9e7308e 100644 (file)
--- a/drivers/crypto/cavium/nitrox/nitrox_mbx.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_mbx.c
@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <linux/bitmap.h>
 #include <linux/workqueue.h>
 
 #include "nitrox_csr.h"
@@ -120,6 +121,7 @@ static void pf2vf_resp_handler(struct work_struct *work)
 
 void nitrox_pf2vf_mbox_handler(struct nitrox_device *ndev)
 {
+       DECLARE_BITMAP(csr, BITS_PER_TYPE(u64));
        struct nitrox_vfdev *vfdev;
        struct pf2vf_work *pfwork;
        u64 value, reg_addr;
@@ -129,7 +131,8 @@ void nitrox_pf2vf_mbox_handler(struct nitrox_device *ndev)
        /* loop for VF(0..63) */
        reg_addr = NPS_PKT_MBOX_INT_LO;
        value = nitrox_read_csr(ndev, reg_addr);
-       for_each_set_bit(i, (const unsigned long *)&value, BITS_PER_LONG) {
+       bitmap_from_u64(csr, value);
+       for_each_set_bit(i, csr, BITS_PER_TYPE(csr)) {
                /* get the vfno from ring */
                vfno = RING_TO_VFNO(i, ndev->iov.max_vf_queues);
                vfdev = ndev->iov.vfdev + vfno;
@@ -151,7 +154,8 @@ void nitrox_pf2vf_mbox_handler(struct nitrox_device *ndev)
        /* loop for VF(64..127) */
        reg_addr = NPS_PKT_MBOX_INT_HI;
        value = nitrox_read_csr(ndev, reg_addr);
-       for_each_set_bit(i, (const unsigned long *)&value, BITS_PER_LONG) {
+       bitmap_from_u64(csr, value);
+       for_each_set_bit(i, csr, BITS_PER_TYPE(csr)) {
                /* get the vfno from ring */
                vfno = RING_TO_VFNO(i + 64, ndev->iov.max_vf_queues);
                vfdev = ndev->iov.vfdev + vfno;