PCI/AER: Simplify AER_RECOVER_RING_SIZE definition
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 27 May 2020 21:01:48 +0000 (16:01 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 25 Aug 2023 13:15:18 +0000 (08:15 -0500)
ACPI Platform Error Interfaces (APEI) convey error information to the OS.
If the APEI GHES driver receives information about PCI errors, it queues it
in aer_recover_ring for processing by the PCI AER code.

AER_RECOVER_RING_SIZE is the size of the aer_recover_ring FIFO and is
arbitrary, with no direct connection to hardware.

AER_RECOVER_RING_ORDER was only used to compute AER_RECOVER_RING_SIZE.
Remove it and define AER_RECOVER_RING_SIZE directly.  No functional change
intended.

Link: https://lore.kernel.org/r/20230824193712.542167-7-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/pci/pcie/aer.c

index 2bc03937452bdb2ff6637a169e233ad1d776a6ee..a30784dabdd7bf8063a1da62106094902b500a7c 100644 (file)
@@ -981,8 +981,7 @@ static void handle_error_source(struct pci_dev *dev, struct aer_err_info *info)
 
 #ifdef CONFIG_ACPI_APEI_PCIEAER
 
-#define AER_RECOVER_RING_ORDER         4
-#define AER_RECOVER_RING_SIZE          (1 << AER_RECOVER_RING_ORDER)
+#define AER_RECOVER_RING_SIZE          16
 
 struct aer_recover_entry {
        u8      bus;