Turn v8.h into a normal header.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1293593005

Cr-Commit-Position: refs/heads/master@{#30265}

diff --git a/src/DEPS b/src/DEPS
index 4b95456..7350f61 100644 (file)
--- a/src/DEPS
+++ b/src/DEPS
@@ -14,9 +14,10 @@ include_rules = [
 
 specific_include_rules = {
   ".*\.h": [
-    # Note that src/v8.h is the top header for some .cc files, it shouldn't be
-    # included in any .h files though. In the long run we should make src/v8.h
-    # act like any normal header file, instead of a grab-bag include.
+    # Note that src/v8.h by now is a regular header file, it doesn't provide
+    # any special declarations besides the V8 class. There should be no need
+    # for including it in any .h files though. This rule is just a reminder,
+    # and can be removed once the dust has settled.
     "-src/v8.h",
   ],
   "d8\.cc": [

diff --git a/src/compiler/DEPS b/src/compiler/DEPS
deleted file mode 100644 (file)
index 60e2f6d..0000000
--- a/src/compiler/DEPS
+++ /dev/null
@@ -1,3 +0,0 @@
-include_rules = [
-  "-src/v8.h",
-]

diff --git a/src/interpreter/DEPS b/src/interpreter/DEPS
index f6fc3f6..f8d6b98 100644 (file)
--- a/src/interpreter/DEPS
+++ b/src/interpreter/DEPS
@@ -1,4 +1,3 @@
 include_rules = [
   "+src/compiler/interpreter-assembler.h",
-  "-src/v8.h",
 ]

diff --git a/src/v8.h b/src/v8.h
index 23e1a12..da5fe46 100644 (file)
--- a/src/v8.h
+++ b/src/v8.h
@@ -2,13 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-//
-// Top include for all V8 .cc files.
-//
-
 #ifndef V8_V8_H_
 #define V8_V8_H_
 
+#include "include/v8.h"
+#include "src/allocation.h"
+
 #if defined(GOOGLE3) || defined(DCHECK_ALWAYS_ON)
 // Google3 and Chromium special flag handling.
 #if defined(DEBUG) && defined(NDEBUG)
@@ -25,13 +24,6 @@
 #error both DEBUG and NDEBUG are set
 #endif
 
-// Basic includes
-#include "include/v8.h"
-#include "src/allocation.h"
-
-// Objects
-#include "src/objects-inl.h"
-
 namespace v8 {
 namespace internal {