f2fs: drop inplace IO if fs status is abnormal
authorChao Yu <yuchao0@huawei.com>
Thu, 22 Apr 2021 10:19:25 +0000 (18:19 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 26 Apr 2021 16:50:39 +0000 (09:50 -0700)
If filesystem has cp_error or need_fsck status, let's drop inplace IO
to avoid further corruption of fs data.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/segment.c

index efd1e57..efac388 100644 (file)
@@ -3552,7 +3552,13 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
                set_sbi_flag(sbi, SBI_NEED_FSCK);
                f2fs_warn(sbi, "%s: incorrect segment(%u) type, run fsck to fix.",
                          __func__, segno);
-               return -EFSCORRUPTED;
+               err = -EFSCORRUPTED;
+               goto drop_bio;
+       }
+
+       if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) || f2fs_cp_error(sbi)) {
+               err = -EIO;
+               goto drop_bio;
        }
 
        stat_inc_inplace_blocks(fio->sbi);
@@ -3567,6 +3573,15 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio)
        }
 
        return err;
+drop_bio:
+       if (fio->bio) {
+               struct bio *bio = *(fio->bio);
+
+               bio->bi_status = BLK_STS_IOERR;
+               bio_endio(bio);
+               fio->bio = NULL;
+       }
+       return err;
 }
 
 static inline int __f2fs_get_curseg(struct f2fs_sb_info *sbi,