bpf: remove redundant variable old_flags
authorColin Ian King <colin.king@canonical.com>
Wed, 11 Oct 2017 10:56:23 +0000 (11:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Oct 2017 03:22:34 +0000 (20:22 -0700)
Variable old_flags is being assigned but is never read; it is redundant
and can be removed.

Cleans up clang warning: Value stored to 'old_flags' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
kernel/bpf/cgroup.c

index e88abc0..3db5a17 100644 (file)
@@ -192,7 +192,6 @@ int __cgroup_bpf_attach(struct cgroup *cgrp, struct bpf_prog *prog,
        struct cgroup_subsys_state *css;
        struct bpf_prog_list *pl;
        bool pl_was_allocated;
-       u32 old_flags;
        int err;
 
        if ((flags & BPF_F_ALLOW_OVERRIDE) && (flags & BPF_F_ALLOW_MULTI))
@@ -239,7 +238,6 @@ int __cgroup_bpf_attach(struct cgroup *cgrp, struct bpf_prog *prog,
                pl->prog = prog;
        }
 
-       old_flags = cgrp->bpf.flags[type];
        cgrp->bpf.flags[type] = flags;
 
        /* allocate and recompute effective prog arrays */