Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)" (#45320)

* Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)"

This reverts commit b79e4d3cd24f76dd1bcb722f589327c827e66632.

* Add a change to ensure libraries are built/tested

diff --git a/src/coreclr/crossgen-corelib.proj b/src/coreclr/crossgen-corelib.proj
index a394fa7..f4ff62f 100644 (file)
--- a/src/coreclr/crossgen-corelib.proj
+++ b/src/coreclr/crossgen-corelib.proj
@@ -5,7 +5,7 @@
   <Target Name="Build">
     <PropertyGroup>
       <!-- Default for using Crossgen2 when not set externally -->
-      <UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">true</UseCrossgen2>
+      <UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">false</UseCrossgen2>
 
       <OSPlatformConfig>$(TargetOS).$(TargetArchitecture).$(Configuration)</OSPlatformConfig>
       <RootBinDir>$(RepoRoot)\artifacts</RootBinDir>

diff --git a/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs b/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs
index 370535d..b13548c 100644 (file)
--- a/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs
+++ b/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs
@@ -16,7 +16,7 @@ namespace System.Threading.Channels
         protected static readonly Action<object?> s_availableSentinel = AvailableSentinel; // named method to help with debugging
         private static void AvailableSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(AvailableSentinel)} invoked with {s}");
 
-        /// <summary>Sentinel object used in a field to indicate the operation has completed.</summary>
+        /// <summary>Sentinel object used in a field to indicate the operation has completed</summary>
         protected static readonly Action<object?> s_completedSentinel = CompletedSentinel; // named method to help with debugging
         private static void CompletedSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(CompletedSentinel)} invoked with {s}");